Code Review Checklist
ADVERTISEMENT
1Code Review Checklist
Review Information:
Coding Standards
understandable
Name of Reviewer:
adhere code guidelines
indentation
Name of Coder:
no magic numbers
File(s) under review:
naming
units, bounds
Brief description of change being reviewed:
spacing: horizontal (btwn
operators, keywords) and
vertical (btwn methods, blocks)
Comments
Review Notes (problems or decisions):
no needless comments
no obsolete comments
no redundant comments
methods document parameters
it modifies, functional
dependencies
comments consistent in format,
length, level of detail
no code commented out
Logic
array indexes within bounds
conditions correct in ifs, loops
loops always terminate
division by zero
refactor statements in the loop
to outside the loop
Error Handling
error messages understandable
and complete
edge cases (null, 0, negative)
parameters valid
files, other input data valid
Code Decisions
code at right level of
abstraction
methods have appropriate
number, types of parameters
no unnecessary features
redundancy minimized
mutability minimized
static preferred over nonstatic
appropriate accessibility
(public, private, etc.)
enums, not int constants
defensive copies when needed
no unnecessary new objects
variables in lowest scope
objects referred to by their
SVN Versions (if applicable):
interfaces, most generic
Before review:
supertype
After revisions:
ADVERTISEMENT
0 votes
Related Articles
Related forms
Related Categories
Parent category: Life